TitlePlugin tag not writing output
Date17-May-2005 22:06:00 EEST
Bug criticalityJSPWiki:BadBug
Browser versionIE6
Bug statusClosedBug
PageProvider used
Servlet ContainerTomcat 5.0.28
Operating SystemWindows 2000
Java version4.1

1) the code of the Plugin tag is in doAfterBody() This method is only called when there is a body. So the sample <wiki:Plugin plugin="ReferringPagesPlugin" args="page='AnyPage'"/> does not work. If I create a tag with body I see the plugin is getting evaluated: <wiki:Plugin plugin="ReferringPagesPlugin" args="page='AnyPage'"> Aaa </wiki:Plugin>

2) No output was written. Replacing pageContext.getOut().write( result ) with getPreviousOut().write( result) and I got the desired output.

Not sure what the flow should be if body is needed for some plugins so it works both for empty tags and tags with body.

I did a google search, seems it is not defined if the doAfterBody() is called if there is no body.

Hmm. I set it to 'BadBug' based on the definition:
  1. Medium Bug - A bug that causes more than annoyance; but it can be worked around.
  2. Bad Bug - A bug that cannot be worked around. Functionality that is not working properly.

as I did not see a workaround.

But now I look at the BadBug page, the definition there is different from the overview page These are bugs that prevent JSPWiki from running in certain configurations, cause crashes, and in general, all HTTP 500 messages. See BugCriticality for more information.

Fixed in 2.2.19. This turned out to be a bit complicated...

-- JanneJalkanen

on doing a refresh doesn't the plugin isn't executed, looks like tag is not reloaded and m_evaluated is not reset (Tomcat 4.1.31) seting m_evaluated=false in doWikiStartTag should probably work -- Arent-Jan

Ah, of course. Tags are pooled... -- JanneJalkanen

Just to nag you, the following two import statements are no longer used and can be removed: -import javax.servlet.jsp.PageContext; -import com.ecyrd.jspwiki.WikiContext; -- Arent-Jan

Well, while I was at it... :)

It's fixed in 2.2.20.

Add new attachment

Only authorized users are allowed to upload new attachments.
« This page (revision-10) was last changed on 09-Jun-2005 20:13 by Administrator