|Title|Recent Chagnes plugin table cosmetic problem
|Date|21-Feb-2007 17:15:27 EET
|Version|2.4.91
|Submitter|146.23.68.25
|[Bug criticality]|CosmeticBug
|Browser version|firefox
|[Bug status]|ClosedBug
|[PageProvider] used|?
|Servlet Container|Tomcat
|Operating System|any
|URL|n/a
|Java version|1.5

The Recent Changes plugin contains a table with 4 columns (page, time, IP and notes).

The table is divided into date groups with row that spans across the table that contains a date.  The generated table row for the date only spans three columns, even though the other generated rows in the table have 4 columns.


----

The issue is this line in RecentChangesPlugin.java 

{{{
    col.setColSpan(3).setClass("date");
}}}

Changing it to this to account for the conditional compact or not compact fixes the display issue.

{{{
    // if compact mode is requested, make the colspan 4, otherwise, make it 2
    col.setColSpan("compact".equals( params.get(PARAM_FORMAT) )? 2 : 4 ).setClass("date");
}}}

If compact is on, author and change notes are omitted, giving a two column table, if compact is not on, they are included giving a 4 column table.  Either way, the current hard coded colspan of "3" is wrong.

--[Eric|mailto:eric.ladner@gmail.com], 09-Mar-2007

----

Yup, this is an oversight.  Thanks for reporting!

-- JanneJalkanen

----

Fixed in JSPWiki 2.5.79-alpha.

-- JanneJalkanen, 12-Jun-2007