TitleTemplateManager RESOURCE-STYLESHEET nok
Date25-Mar-2006 13:06:17 EET
Versionv2.3.81
SubmitterDirk Frederickx
Bug criticalityLightBug
Browser versionsafari
Bug statusClosedBug
PageProvider used
Servlet Containertomcat
Operating System
URL
Java version1.4.2

I am writing a plugin which needs to include an additional css stylesheet. Unfortunately, the jspwiki rendered html is incorrect :

File: com.ecrid.jspwiki.ui.TemplateManager.java

        }
        else if( type == RESOURCE_STYLESHEET )
        {
            resourceString = "<link rel='stylesheet' type='text/css' src='"+path+"' />";
        }

should become

        }
        else if( type == RESOURCE_STYLESHEET )
        {
            resourceString = "<link rel='stylesheet' type='text/css' href='"+path+"' />";
        }


BTW, I would be happy to use an extra addResourceRequest type "RESOURCE_CSSINCLUDE" which would allow a plugin to insert inline css in the header of the page. ( similar to JSFUNCTION ) This should render as

   <style type='text/css' >...</style>
My plugin is currently inserting the inline css inside the body of the page, which seems to work fine, but this breaks the xhtml compliance of the page.

tx --DF


Good idea, and easily implemented. I fixed this bug and added your new request type (RESOURCE_INLINECSS) to 2.3.90.

-- JanneJalkanen


Thanks ! --DF

Add new attachment

Only authorized users are allowed to upload new attachments.
« This page (revision-3) was last changed on 25-Mar-2006 20:56 by Dirk Frederickx